Skip to content

We should deprecate .and() along with non lambda DSL methods #12629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #12647
rwinch opened this issue Feb 3, 2023 · 2 comments
Closed
Tracked by #12647

We should deprecate .and() along with non lambda DSL methods #12629

rwinch opened this issue Feb 3, 2023 · 2 comments
Assignees
@marcusdacoregio
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Milestone
6.1.0-RC1

Comments

@rwinch
Copy link
Member

rwinch commented Feb 3, 2023

We should encourage users to switch over to the lambda DSL by deprecating methods that are only valid for the old way (using and()) of configuring Spring Security.
@rwinch rwinch added in: build An issue in the build type: task A general task labels Feb 3, 2023
@rwinch rwinch self-assigned this Feb 3, 2023
@rwinch rwinch removed their assignment Apr 11, 2023
@jgrandja jgrandja mentioned this issue Apr 11, 2023
Closed
1 task
@marcusdacoregio marcusdacoregio self-assigned this Apr 11, 2023
@marcusdacoregio marcusdacoregio mentioned this issue Apr 12, 2023
Open
6 tasks
@marcusdacoregio marcusdacoregio added in: config An issue in spring-security-config and removed in: build An issue in the build labels Apr 13, 2023
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Apr 14, 2023
@marcusdacoregio
Deprecate .and() and non lambda DSL methods
29153a3 
Closes spring-projectsgh-12629
@philwebb philwebb mentioned this issue Apr 14, 2023
Closed
@wilkinsona
Copy link
Member

I wonder if this should be an enhancement rather than a task so that it appears in the changelog? It's something that users may want to learn about when reviewing what's changed. It's also a breaking change for anyone compiling with -Werror so it feels worth listing from that perspective as well.

@marcusdacoregio marcusdacoregio added type: enhancement A general enhancement and removed type: task A general task labels Apr 15, 2023
@marcusdacoregio marcusdacoregio added this to the 6.1.0-RC1 milestone Apr 15, 2023
@marcusdacoregio
Copy link
Contributor

Thanks @wilkinsona , I updated the issue

This was referenced Apr 18, 2023
Open
Open
Closed
@marcusdacoregio marcusdacoregio mentioned this issue Apr 26, 2023
Closed
jzheaux added a commit to krzyk/spring-security that referenced this issue Jun 5, 2023
@jzheaux
Update Deprecated Usage
1abea13 
Issue spring-projectsgh-12629
jzheaux added a commit that referenced this issue Jun 22, 2023
@jzheaux
Update Deprecated Usage
208fb62 
Issue gh-12629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-RC1
Development

No branches or pull requests
3 participants
@rwinch @wilkinsona @marcusdacoregio