Add Cross Origin Policies headers DSL support #10141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusdacoregio
added
status: duplicate
eleftherias
suggested changes
Dec 2, 2021
There was a problem hiding this comment.
Thanks @marcusdacoregio!
I have left some feedback inline.
Also, since 5.6 was already released, the @since tags should be updated to 5.7.
...n/java/org/springframework/security/config/annotation/web/configurers/HeadersConfigurer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/security/web/header/writers/CrossOriginPoliciesHeadersWriter.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/web/server/header/CrossOriginPoliciesServerHttpHeadersWriter.java
Outdated
Show resolved
Hide resolved
marcusdacoregio
force-pushed
the
gh-9385
branch
2 times, most recently
from
9413b38 to
5099cae
Compare
|
Thanks for the review @eleftherias. I've updated the PR based on your suggestions. |
eleftherias
reviewed
Dec 6, 2021
config/src/test/java/org/springframework/security/config/web/server/HeaderSpecTests.java
Outdated
Show resolved
Hide resolved
marcusdacoregio
force-pushed
the
gh-9385
branch
from
5099cae to
279be01
Compare
Add DSL support for Cross-Origin-Opener-Policy, Cross-Origin-Embedder-Policy and Cross-Origin-Resource-Policy headers Closes spring-projectsgh-9385, spring-projectsgh-10118
marcusdacoregio
force-pushed
the
gh-9385
branch
from
279be01 to
aa3ee9d
Compare
This was referenced Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DSL support for
Cross-Origin-Opener-Policy,Cross-Origin-Embedder-PolicyandCross-Origin-Resource-Policy headersCloses gh-9385, gh-10118