Skip to content

#12811 - compressing simple class name for observation #12955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bvn13
Copy link
Contributor

@bvn13 bvn13 commented Mar 31, 2023

I tried to compile the project locally in order to test it.
But unfortunately I had the error below. And I definitely don't know how to fix it.
I would try to check open-telemetry locally if you help me to compile the project.

 ./gradlew build
> Task :buildSrc:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':buildSrc:compileJava'.
> error: invalid source release: 17

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.5.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 1s
5 actionable tasks: 1 executed, 4 up-to-date

A build scan was not published as you have not authenticated with server 'ge.spring.io'.
For more information, please see https://gradle.com/help/gradle-authenticating-with-gradle-enterprise

@pivotal-cla
Copy link

@bvn13 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@bvn13 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 31, 2023
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bvn13! I'd be happy to help you get your application compiling. Have you already tried following the instructions in the README?

Also, I realize that my suggestion in the PR is more work than you may feel you have time for. If you decide to do it, then let's please when you update your PR, please ensure that your commit is formatted like so:

Compress Filter Chain Observation Names

Closes gh-12811

@bvn13
Copy link
Contributor Author

bvn13 commented Apr 9, 2023

@jzheaux Please take a look at my PR

@jzheaux jzheaux self-assigned this Apr 11, 2023
@jzheaux jzheaux force-pushed the feature/12811/compress-simple-class-name-for-observation branch from 9b5492b to 9083dbd Compare April 12, 2023 00:09
@jzheaux jzheaux merged commit 02345b9 into spring-projects:main Apr 12, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Apr 12, 2023

Thanks for your help with this PR, @bvn13! I made a polish to use the simple name and adjusted the observations a bit. Also, I removed the OpenTelemetry-specific code as per our discussion.

For the time being, I'd like to wait on configuration, so I also removed the registerName method. I think that at some point we could have a setter were a set of event names could be provided or similar, but for now I'm not clear on how filter chain observation is going to evolve.

This is now merged into main; thanks again!

@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 12, 2023
@jzheaux jzheaux added this to the 6.1.0-RC1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants