-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Remove GET request support from Saml2AuthenticationTokenConverter #17108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+73
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaa03b3
to
e6186a1
Compare
jzheaux
requested changes
May 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ngocnhan-tran1996! I've left some feedback inline.
...g/springframework/security/saml2/provider/service/web/Saml2AuthenticationTokenConverter.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/saml2/provider/service/web/Saml2AuthenticationTokenConverter.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/saml2/provider/service/web/Saml2AuthenticationTokenConverter.java
Outdated
Show resolved
Hide resolved
...ingframework/security/saml2/provider/service/web/Saml2AuthenticationTokenConverterTests.java
Outdated
Show resolved
Hide resolved
7b90e07
to
6e793e8
Compare
2 tasks
12d1aa0
to
d3af0af
Compare
Closes spring-projectsgh-17099 Signed-off-by: Tran Ngoc Nhan <[email protected]>
jzheaux
approved these changes
Jun 3, 2025
Thanks, @ngocnhan-tran1996! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can define
Boolean shouldInflate
and methoddecode
will be addedIf not, this will break
Saml2LoginBeanDefinitionParserTests
andSaml2AuthenticationTokenConverterTests
Issue: gh-17099