Update OncePerRequestFilter to match with spring-web

[bboyz269]

Call "getAlreadyFilteredAttributeName()" instead of direct usage if private "this.alreadyFilteredAttributeName"

Fix the error of the property value is null when proxied by CGLIB (bean from extending SessionRepositoryFilter)

[eleftherias]

Thanks for the PR @bboyz269!

Could you add a test demonstrating the bug?

Also, please add Closes gh-1658 to the commit message, so that the issue you reported is automatically closed when this is merged.

[bboyz269]

I'm not sure what would be suffice for the test you mention but I'll look it up as soon as I get available time at a PC.On Jul 17, 2020 9:28 PM, Eleftheria Stein-Kousathana <[email protected]> wrote: @eleftherias requested changes on this pull request. Thanks for the PR @bboyz269! Could you add a test demonstrating the bug? Also, please add Closes gh-1658 to the commit message, so that the issue you reported is automatically closed when this is merged. —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

[rwinch]

I think a unit test demonstrating that a subclass of OncePerRequestFilter that has overridden getAlreadyFilteredAttributeName will still work is sufficient.

[bboyz269]

I think a unit test demonstrating that a subclass of OncePerRequestFilter that has overridden getAlreadyFilteredAttributeName will still work is sufficient.

Not quite, it has to be a subclass being proxied by Spring AOP.

@eleftherias I add a new test class OncePerRequestFilterAopTests, would you check it out?

[eleftherias]

Thanks for the updates @bboyz269!

In the original issue that you reported, gh-1658, was the class also being proxied by Spring AOP?

[bboyz269]

In the original issue that you reported, gh-1658, was the class also being proxied by Spring AOP?

Yes, it was being proxied by Spring AOP with CGLIb.

[eleftherias]

Thanks for the clarification @bboyz269.
I just notice 2 small typos.
Once these are fixed, we can merge this PR.

[eleftherias]

Thanks for the PR @bboyz269! This is now merged into master.