`_rev_file` regex is too strict

[sqlalchemy-bot]

Migrated issue, originally created by eevee (@eevee)

From alembic/script.py:

_rev_file = re.compile(r'([a-z0-9A-Z]+)(?:_.*)?\.py$')

I originally tried defining my scripts to look like 20120916-abcdef-do_something.py, but this regex quietly ignored them.

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

should be able to pare that regexp down to something like ".*.py$", am at the top of a large issue backlog right now.

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

b3f20c6

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed

[sqlalchemy-bot]

Sok Ann Yap (@sayap) wrote:

This regexp matches __init__.py, subsequently triggers the "Could not determine revision id from filename" error.

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

OK this is what I was trying to understand. Why is there an __init__.py in your versions/ directory ?

[sqlalchemy-bot]

Sok Ann Yap (@sayap) wrote:

Good question. I was having some problem with setup.py bdist_egg not picking up the migration files until I added the __init__.py file. Seems to work fine now without the file. Hmm.

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

probably something to do with packages. but versions/ is not intended to be a package (that is, the __init__.py file makes it a package).

[sqlalchemy-bot]

Sok Ann Yap (@sayap) wrote:

My "seems to work fine" comment was wrong. Before I removed the __init__.py, my <package>.egg-info/SOURCES.txt contains all the migration .py files. After I removed __init__.py and rerun python setup.py egg_info, the file itself was gone from SOURCES.txt, but all the migration .py files were intact.

This gave me the false impression that things work fine, until I added additional migration .py files and found that they are no longer being added to SOURCES.txt.

After blowing away the whole <package>.egg-info directory and rerun python setup.py egg_info, now the whole alembic versions directory can't be found in SOURCES.txt, which was the original symptom that got me to add the __init__.py file.

I fix this by modifying my project MANIFEST.in and make sure it has:

recursive-include <package> ... *.py

By default, a pyramid project doesn't have *.py in the line.

tl;dr blame setuptools

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

yeah, distutils/setuptools only installs packages by default. A package requires an __init__.py. The versions/ directory is not intended to be a package, so needs special directives.

Now, I'm not opposed to modifying this requirement, such that a versions/ directory can have an __init__.py that would be ignored, just so that in case someone's configuration has turned their versions/ into a package, things are OK.

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

the discussion re __init__.py has moved to #95.