Wrong scope indent reported in anonymous class

[ondrejmirtes]

With this code sample:

    public function testDynamicMethodReturnTypeExtensions(
        string $typeClass,
        bool $nullable,
        string $class = null,
        string $expression
    )
    {
        $this->assertTypes(
            __DIR__ . '/data/dynamic-method-return-types.php',
            $typeClass,
            $nullable,
            $class,
            $expression,
            [
                new class() implements DynamicMethodReturnTypeExtension {

                    public static function getClass(): string
                    {
                        return \DynamicMethodReturnTypesNamespace\EntityManager::class;
                    }

                    public function isMethodSupported(MethodReflection $methodReflection): bool
                    {
                        return in_array($methodReflection->getName(), ['getByPrimary'], true);
                    }

                    public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): \PHPStan\Type\Type
                    {
                        $args = $methodCall->args;
                        if (count($args) === 0) {
                            return $methodReflection->getReturnType();
                        }

                        $arg = $args[0]->value;
                        if (!($arg instanceof \PhpParser\Node\Expr\ClassConstFetch)) {
                            return $methodReflection->getReturnType();
                        }

                        if (!($arg->class instanceof \PhpParser\Node\Name)) {
                            return $methodReflection->getReturnType();
                        }

                        return new ObjectType((string) $arg->class, false);
                    }
                },
            ]
        );
    }

CodeSniffer reports wrong indentation on some lines in the anonymous class. It stops complaining when I format the code like this:

    public function testDynamicMethodReturnTypeExtensions(
        string $typeClass,
        bool $nullable,
        string $class = null,
        string $expression
    )
    {
        $this->assertTypes(
            __DIR__ . '/data/dynamic-method-return-types.php',
            $typeClass,
            $nullable,
            $class,
            $expression,
            [
                new class() implements DynamicMethodReturnTypeExtension {

            public static function getClass(): string
            {
                return \DynamicMethodReturnTypesNamespace\EntityManager::class;
            }

            public function isMethodSupported(MethodReflection $methodReflection): bool
            {
                return in_array($methodReflection->getName(), ['getByPrimary'], true);
            }

            public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): \PHPStan\Type\Type
            {
                $args = $methodCall->args;
                if (count($args) === 0) {
                    return $methodReflection->getReturnType();
                }

                $arg = $args[0]->value;
                if (!($arg instanceof \PhpParser\Node\Expr\ClassConstFetch)) {
                    return $methodReflection->getReturnType();
                }

                if (!($arg->class instanceof \PhpParser\Node\Name)) {
                    return $methodReflection->getReturnType();
                }

                return new ObjectType((string) $arg->class, false);
            }
                },
            ]
        );

Which looks wrong to me.

[gsherwood]

Simple example:

<?php
$foo = [
        new class() implements Bar {

            public static function foo(): string
            {
                return 'foo';
            }
        },
];

The Scope Indent debug output is:

$ phpcs temp.php --standard=Generic --sniffs=Generic.WhiteSpace.ScopeIndent --runtime-set scope_indent_debug 1

Start with token 0 on line 1 with indent 0
Open scope (T_ANON_CLASS) on line 3
    => indent set to 4 by token 18 (T_OPEN_CURLY_BRACKET)
[Line 5] Line indented incorrectly; expected 4 spaces, found 12
    => Add adjustment of -8 for token 22 (T_PUBLIC) on line 5
Open scope (T_FUNCTION) on line 6
    => indent set to 8 by token 36 (T_OPEN_CURLY_BRACKET)
Indent adjusted to 8 for T_RETURN on line 7
    => Add adjustment of -8 for token 39 (T_RETURN) on line 7
Close scope (T_FUNCTION) on line 8
    => indent set to 4 by token 45 (T_CLOSE_CURLY_BRACKET)
[Line 8] Line indented incorrectly; expected 4 spaces, found 12
    => Add adjustment of -8 for token 45 (T_CLOSE_CURLY_BRACKET) on line 8
Close scope (T_ANON_CLASS) on line 9
    => indent set to 8 by token 48 (T_CLOSE_CURLY_BRACKET)
Closing short array bracket found on line 10
    * first token on line 2 is 1 (T_VARIABLE) *
    => checking indent of 0; main indent set to 0 by token 1 (T_VARIABLE)

FILE: temp.php
------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------
 5 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
 8 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

Time: 9ms; Memory: 2Mb

The sniff is not using the indent of the anon class to set the general indent. It is just increasing the indent one level. Which is perfectly fine for this sort of code:

$foo = new class() implements Bar {
    public static function foo(): string
    {
        return 'foo';
    }
};

But obviously not when the class (or a function I assume) is inside an array and thus inside a custom indentation block.

Edit: I forgot that closures already have their own custom rules.

[gsherwood]

I've changed the sniff to treat anon classes the same way closures are treated. The sniff no longer throws any errors for your first code sample, but does throw errors for the second one (the one that looks wrong, because it is wrong). PHPCBF will fix that second block to look like the first.

Thanks a lot for the report.

[ondrejmirtes]

Cool, great! :)