Improve formatting of the end brace when auto fixing InlineControlStructure errors

[benwaffle]

run cbf with psr2 on:

<?php

foreach ($activeStudents7 as $n) {
    if (!isset($rows[$n->$level_id]))
        continue; // archived entities
    $rows[$n->$level_id]['num_active_7']++;
    $rows[$n->$level_id]['total_hours_7'] += $n->minutes / 60.0;
}

the outcome is:

<?php

foreach ($activeStudents7 as $n) {
    if (!isset($rows[$n->$level_id])) {
        continue; // archived entities
    }    $rows[$n->$level_id]['num_active_7']++;
    $rows[$n->$level_id]['total_hours_7'] += $n->minutes / 60.0;
}

[gsherwood]

It looks like the brace is on the correct line, so maybe you're just asking for it to be placed on a line by itself?

[benwaffle]

$rows[$n->$level_id]['num_active_7']++; should be on its own line, not the same line as the closing brace

[gsherwood]

I thought that was what you were asking, but wanted to confirm before changing anything.

I agree that this would be a good change.

[gsherwood]

I've committed a change to improve the placement of the brace. After the change, the original code is now auto fixed like this:

<?php

foreach ($activeStudents7 as $n) {
    if (!isset($rows[$n->$level_id])) {
        continue; // archived entities
    }
    $rows[$n->$level_id]['num_active_7']++;
    $rows[$n->$level_id]['total_hours_7'] += $n->minutes / 60.0;
}