Using curly braces for a shared CASE/DEFAULT statement can generate an error in PSR2 SwitchDeclaration

[mkasberg]

SwitchDeclarationSniff is throwing PHP Notices:

PHP Notice:  Undefined index: scope_condition in phar:///usr/local/bin/phpcs/CodeSniffer/Standards/PSR2/Sniffs/ControlStructures/SwitchDeclarationSniff.php on line 157
PHP Stack trace:
PHP   1. {main}() /usr/local/bin/phpcs:0
PHP   2. PHP_CodeSniffer_CLI->runphpcs() /usr/local/bin/phpcs:6
PHP   3. PHP_CodeSniffer_CLI->process() phar:///usr/local/bin/phpcs/CodeSniffer/CLI.php:104
PHP   4. PHP_CodeSniffer->processFiles() phar:///usr/local/bin/phpcs/CodeSniffer/CLI.php:886
PHP   5. PHP_CodeSniffer->processFile() phar:///usr/local/bin/phpcs/CodeSniffer.php:619
PHP   6. PHP_CodeSniffer->_processFile() phar:///usr/local/bin/phpcs/CodeSniffer.php:1714
PHP   7. PHP_CodeSniffer_File->start() phar:///usr/local/bin/phpcs/CodeSniffer.php:1836
PHP   8. PSR2_Sniffs_ControlStructures_SwitchDeclarationSniff->process() phar:///usr/local/bin/phpcs/CodeSniffer/File.php:567

[gsherwood]

The only way to track this down is if you can provide the file that you were checking, or a small snippet of code that causes the same problem. Is this possible?

Can you also let me know what version of PHPCS you are using (phpcs --version) please.

[mkasberg]

Thanks for the response.

I was able to track down a code snippet that reproduces the problem. This is happening with phpcs version 2.5.1 when run against a file containing only the following code:

<?php

function get_date_format_from_resolution(
    $strResolution = "day",
    $bPadResult = false
    )
{
    $strRetval = "";

    switch(strtolower($strResolution))
    {
        case("year"):
        {
            $strRetval = "%Y" . ($bPadResult ? "-01-01 00:00:00" : "");
            break;
        }

        case("day"):
        default:
        {
            $strRetval = "%Y-%m-%d" . ($bPadResult ? " 00:00:00" : "");
            break;
        }
    }

    $strRetval = "'" . $strRetval . "'";

    return $strRetval;
}

[gsherwood]

Thanks for posting that code. I'm now using this code to reproduce:

<?php
switch($foo)
{
    case('foo'):
    default:
    {
        $foo = 'foo';
        break;
    }
}

[gsherwood]

Turned out to be a core tokenizer issue, but only encountered by the PSR2 sniff. It's fixed now.

Thanks for the bug report.