Skip to content

Build does not produce binaries #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzz opened this issue Apr 27, 2018 · 6 comments
Closed

Build does not produce binaries #255

bzz opened this issue Apr 27, 2018 · 6 comments

Comments

@bzz
Copy link
Contributor

bzz commented Apr 27, 2018

A week ago, very same instructions worked and I was able to build our awesome gitbase project, but now It seems that current make packages does not produce a valid binary on non-linux OSes any more.

Steps to reproduce

Following the CI:

export GOPATH="/tmp/gitbase-gopath"
mkdir -p $GOPATH
go get github.com/src-d/gitbase/cmd/gitbase
cd $GOPATH/src/github.com/src-d/gitbase

cd ./vendor/gopkg.in/bblfsh/client-go.v2
make dependencies
cd -
make dependencies
make packages

Expected

a runnable binary at ./build/gitbase_darwin_amd64/gitbase

Actual

Makefile:17: warning: overriding commands for target `dependencies'
/private/tmp/gitbase-gopath/src/github.com/src-d/gitbase/.ci/Makefile.main:99: warning: ignoring old commands for target `dependencies'
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
/bin/bash: line 0: cd: /tmp/gitbase-gopath/src/github.com/src-d/gitbase/cmd/gitbase: No such file or directory

and then build output for Darwin arch is no executable,

$./build/gitbase_darwin_amd64/gitbase
zsh: permission denied: ./build/gitbase_darwin_amd64/gitbase

$file ./build/gitbase_darwin_amd64/gitbase
./build/gitbase_darwin_amd64/gitbase: current ar archive

Please feel free to point to a better gitbase build instructions, in case I have missed something.

@smola
Copy link
Contributor

smola commented Apr 27, 2018

I guess since libuast dependency was introduced, we cannot cross-compile for osx that easily, we probably need to add an actual build osx on Travis to produce it now.

@bzz
Copy link
Contributor Author

bzz commented Apr 27, 2018

I see.. was under impression that manual cd ./vendor/.. + make dependency takes care of building a version of libuast for the current platform.

Then, what would be an advised way of building gitbase locally on non-linux OSes for now?

@smola
Copy link
Contributor

smola commented May 3, 2018

@bzz Sorry, I misunderstood. I thought you were talking about cross-compiling osx binaries from Linux. Build instructions should work in OSX AFAIK, so it is a bug if they do not.

@ajnavarro
Copy link
Contributor

I think the problem should be fixed here: #257

@bzz
Copy link
Contributor Author

bzz commented May 3, 2018

@smola at the end, it was not arch specific at all.

@ajnavarro tested locally and #257 resolves the issue, thank you!

@bzz bzz changed the title Build does not produce binary for Darwin arch Build does not produce binaries May 3, 2018
@ajnavarro
Copy link
Contributor

Already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants