feat: custom version for Trino #1168
Open
+139
−86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #1068
This PR enables custom versions (with a suffix like
-stackable0.0.0-dev
) for Trino.In the SBOM, the custom version is replaced by the original one (using
sed
), so vulnerabilities filed directly against Trino are still detected by scanners when scanning the SBOM.Further changes:
trino/trino/Dockerfile
) to differentiate the final Trino image (trino/Dockerfile
) from Trino the application. This was needed sincestorage-connector
uses our patched Trino version now, while the Trino image includesstorage-connector
. Without separating these, so if Trino (app) and Trino (image) would be the same Bake target, we'd have a circular dependency, becausestorage-connector
depends on Trino (app) and Trino (image) depends onstorage-connector
.I successfully built these products and tested them with the smoke tests:
For the smoke test to pass, this PR needs to be merged: stackabletech/trino-operator#760
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.