Skip to content

feat: Integrate listener operator #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 3, 2025
Merged

feat: Integrate listener operator #731

merged 20 commits into from
Jul 3, 2025

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Jun 12, 2025 •
edited
Loading

Description

fixes #682

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@labrenbe labrenbe self-assigned this Jun 12, 2025
@labrenbe labrenbe marked this pull request as ready for review June 26, 2025 13:07
@maltesander maltesander self-requested a review June 27, 2025 13:13
maltesander
maltesander reviewed Jun 30, 2025
View reviewed changes
maltesander
maltesander reviewed Jul 1, 2025
View reviewed changes
maltesander
maltesander approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@labrenbe labrenbe added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 09e8040 Jul 3, 2025
17 checks passed
@labrenbe labrenbe deleted the feat/integrate-listener-operator branch July 3, 2025 07:17
NickLarsenNZ added a commit that referenced this pull request Jul 8, 2025
@NickLarsenNZ
test: Update secret scopes in assertions
49f256e 
This was changed in #731
@NickLarsenNZ NickLarsenNZ mentioned this pull request Jul 8, 2025
Merged
NickLarsenNZ added a commit that referenced this pull request Jul 8, 2025
@NickLarsenNZ
test: Update secret scopes in assertions (#733)
a2f6129 
* test: Update secret scopes in assertions

This was changed in #731

* noop

* noop

* noop
@NickLarsenNZ NickLarsenNZ mentioned this pull request Jul 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@labrenbe labrenbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Druid Operator with Listener Operator
2 participants
@labrenbe @maltesander