[Merged by Bors] - Implement product image selection #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
changed the title
8 tasks
5 tasks
nightkr
approved these changes
Oct 31, 2022
sbernauer
commented
Nov 2, 2022
4 tasks
This was referenced Nov 7, 2022
bors bot
pushed a commit
to stackabletech/operator-rs
that referenced
this pull request
Nov 11, 2022
## Description For #470 Reference implementation in kafka: stackabletech/kafka-operator#482 ADR is [here](https://docs.stackable.tech/home/stable/contributor/adr/ADR018-product_image_versioning.html) The idea is to add all the currently known enum variants to see that the concept works. Before merging the `ProductImageSelection::Stackable` enum variant will be removed/commented out.
bors bot
pushed a commit
to stackabletech/operator-rs
that referenced
this pull request
Nov 11, 2022
## Description For #470 Reference implementation in kafka: stackabletech/kafka-operator#482 ADR is [here](https://docs.stackable.tech/home/stable/contributor/adr/ADR018-product_image_versioning.html) The idea is to add all the currently known enum variants to see that the concept works. Before merging the `ProductImageSelection::Stackable` enum variant will be removed/commented out.
sbernauer
added
release/23.1.0
release-note/action-required
…-selection # Conflicts: # Cargo.lock # examples/logging/simple-kafka-cluster-opa-log4j.yaml # examples/opa/simple-kafka-cluster-opa-allow-all.yaml # examples/tls/simple-kafka-cluster-tls.yaml # rust/crd/Cargo.toml # rust/operator-binary/Cargo.toml # rust/operator/Cargo.toml # rust/operator/src/discovery.rs # rust/operator/src/kafka_controller.rs
Co-authored-by: Sebastian Bernauer <[email protected]>
sbernauer
commented
Dec 13, 2022
|
LGTM when tests pass |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
# Description For stackabletech/operator-rs#470 Reference implementation of stackabletech/operator-rs#476 Co-authored-by: Malte Sander <[email protected]> Co-authored-by: Malte Sander <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For stackabletech/operator-rs#470
Reference implementation of stackabletech/operator-rs#476
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information