-
Notifications
You must be signed in to change notification settings - Fork 84
feat(extension): metadata autocompletion #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
c3dbda2
to
63ece9e
Compare
Deploying tutorialkit-demo-page with
|
Latest commit: |
0966dcf
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f0c04146.tutorialkit-demo-page.pages.dev |
Branch Preview URL: | https://joan-frontmatter-completions.tutorialkit-demo-page.pages.dev |
aff6bbe
to
95e8acf
Compare
7005e34
to
1d4cfa1
Compare
// TODO: those don't work | ||
'src/content/*.md', | ||
'src/content/**/*.md', | ||
'src/content/**/*.mdx', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to investigate that, ideally I don't want the check to apply to every markdown & mdx files.
}, | ||
}); | ||
|
||
delete yamlService.capabilities.codeLensProvider; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed that because otherwise the schema was popping up on each file metadata. It wasn't a really great UX.
Deploying tutorialkit-docs-page with
|
Latest commit: |
0966dcf
|
Status: | ✅ Deploy successful! |
Preview URL: | https://7f829b4a.tutorialkit-docs-page.pages.dev |
Branch Preview URL: | https://joan-frontmatter-completions.tutorialkit-docs-page.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally and it works really nice, like magic! 🪄
The code itself looks fine to me. I haven't used Volar before but the integration looks clear. @d3lm do you want to take a look at this before I merge this?
Yep can take a look if you want 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a few minor remarks. Since @Nemikolh is OOO this week, do you wanna take a stab at the comments @AriPerkkio or do we wanna wait?
I'll handle the PR comments next. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last small remarks but looking good!
Tested extension manually after the latest changes. Works OK. ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
This PR adds a volar based language server to provide autocompletion in the metadata of markdown and mdx files.
All the
describe
properties are here to provide a description for each property.The autocompletion features is entirely provided by the Yaml language server.
TutorialKit-metadata-intellisense.webm