Skip to content

fix(docs): jumping to bottom of getting started page #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

EricSimons
Copy link
Member

No description provided.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Deploying tutorialkit-docs-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: 606d7b7
Status: ✅  Deploy successful!
Preview URL: https://673f8546.tutorialkit-docs-page.pages.dev
Branch Preview URL: https://ericsimons-patch-1.tutorialkit-docs-page.pages.dev

View logs

@d3lm d3lm changed the title Fix docs jumping to bottom of getting started page fix(docs): jumping to bottom of getting started page Jul 25, 2024
Copy link
Contributor

@d3lm d3lm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the title so it matches our convention. LGTM otherwise 👍

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 💯

This doesn't come up easily on desktops as whole page height can fit the viewport easily.

@AriPerkkio AriPerkkio merged commit 55430f9 into main Jul 25, 2024
10 of 11 checks passed
@AriPerkkio AriPerkkio deleted the EricSimons-patch-1 branch July 25, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants