Skip to content

Add tests #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2018
Merged

Add tests #4

merged 2 commits into from
Mar 30, 2018

Conversation

rreusser
Copy link
Member

@rreusser rreusser commented Feb 5, 2018 •
edited
Loading

This PR adds mostly trivial smoke tests so that we can worry a bit less if I submit PRs for #3.

/cc @mattdesl, just to confirm the plan of action and in case there are any red flags. Should just be a couple steps.

  1. add tests (this PR)
  2. add functions in a manner analogous to the recent changes in gl-vec2.
  3. publish

@rreusser rreusser mentioned this pull request Feb 6, 2018
Merged
@mattdesl
Copy link
Member

Looks great! 👍

@rreusser rreusser merged commit 87ed1a2 into master Mar 30, 2018
@rreusser rreusser deleted the add-tests branch March 30, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rreusser @mattdesl