Open
Description
We should be using clippy lints in stackslib
-- many lints are purely stylistic, but we should start by prioritizing lints which avoid panics: while the stackslib crate guards panics and unwraps with checks, clippy lints highlight places in the codebase where the rust type system itself could ensure that the checks are performed correctly.
The lints that I think are worth starting with:
- clippy::indexing_slicing
- clippy::expect_used
- clippy::unwrap_used
These won't be small! I think its also worth remembering that sometimes these patterns should be allowed either for performance, or because in some cases, panics really are more appropriate than attempting to soldier on. However, in these cases, we should force the code to explicitly "allow" the usage.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Status: 🆕 New