-
Notifications
You must be signed in to change notification settings - Fork 696
[clarity-wasm-tests] fix tests failing with CheckErrors::NoSuchContract error #6198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clarity-wasm-tests] fix tests failing with CheckErrors::NoSuchContract error #6198
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (20.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## feat/clarity-wasm-develop #6198 +/- ##
=============================================================
- Coverage 20.51% 20.50% -0.01%
=============================================================
Files 528 529 +1
Lines 392169 392189 +20
Branches 323 323
=============================================================
- Hits 80438 80407 -31
- Misses 311723 311774 +51
Partials 8 8
... and 28 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
6cc8f7f
to
7927cbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite unconvinced in the necessity to add the massive ouroboros crate here. Why not create a new constructor on GlobalContext
that returns it in a tuple with the needed store, so that you have access to everything?
ae1a624
to
f4b5933
Compare
83faf2b
to
b3881ef
Compare
b3881ef
to
dcf76d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so much better without ouroboros !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
71d75d1
into
stacks-network:feat/clarity-wasm-develop
fix stacks-network/clarity-wasm#652