Skip to content

[clarity-wasm-tests] fix tests failing with CheckErrors::NoSuchContract error #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

csgui
Copy link

@csgui csgui commented Jun 13, 2025

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 20.50%. Comparing base (703f050) to head (60d17e4).
Report is 1 commits behind head on feat/clarity-wasm-develop.

Files with missing lines Patch % Lines
clarity/src/vm/contexts.rs 15.78% 16 Missing ⚠️

❌ Your project check has failed because the head coverage (20.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/clarity-wasm-develop    #6198      +/-   ##
=============================================================
- Coverage                      20.51%   20.50%   -0.01%     
=============================================================
  Files                            528      529       +1     
  Lines                         392169   392189      +20     
  Branches                         323      323              
=============================================================
- Hits                           80438    80407      -31     
- Misses                        311723   311774      +51     
  Partials                           8        8              
Files with missing lines Coverage Δ
clarity/src/vm/errors.rs 8.03% <ø> (ø)
clarity/src/vm/tests/clarity_wasm/mod.rs 100.00% <100.00%> (ø)
clarity/src/vm/tests/mod.rs 0.00% <ø> (ø)
clarity/src/vm/contexts.rs 42.12% <15.78%> (+<0.01%) ⬆️

... and 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6199c72...60d17e4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@csgui csgui force-pushed the wasm-issue-652/no-such-contract branch 2 times, most recently from 6cc8f7f to 7927cbc Compare June 16, 2025 13:50
@csgui csgui marked this pull request as ready for review June 16, 2025 14:16
@csgui csgui requested a review from a team as a code owner June 16, 2025 14:16
Copy link
Contributor

@Acaccia Acaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite unconvinced in the necessity to add the massive ouroboros crate here. Why not create a new constructor on GlobalContext that returns it in a tuple with the needed store, so that you have access to everything?

@csgui csgui force-pushed the wasm-issue-652/no-such-contract branch 2 times, most recently from ae1a624 to f4b5933 Compare June 17, 2025 17:08
@csgui csgui requested review from Acaccia and BowTiedWoo June 17, 2025 17:11
@csgui csgui force-pushed the wasm-issue-652/no-such-contract branch from 83faf2b to b3881ef Compare June 17, 2025 17:14
@csgui csgui force-pushed the wasm-issue-652/no-such-contract branch from b3881ef to dcf76d1 Compare June 17, 2025 19:56
@csgui csgui changed the base branch from feat/clarity-wasm-develop to develop June 17, 2025 19:57
@csgui csgui requested review from a team as code owners June 17, 2025 19:57
@csgui csgui changed the base branch from develop to feat/clarity-wasm-develop June 17, 2025 19:57
@csgui csgui removed request for a team June 17, 2025 19:58
Copy link
Contributor

@Acaccia Acaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so much better without ouroboros !!!

Copy link

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

@BowTiedWoo BowTiedWoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csgui csgui merged commit 71d75d1 into stacks-network:feat/clarity-wasm-develop Jun 18, 2025
24 of 47 checks passed
@csgui csgui deleted the wasm-issue-652/no-such-contract branch June 18, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants