Description
Summary:
Function command
in the CmdStan interface in file command.hpp
is 900+ lines long.
Refactor into per-method helper functions in file command_helper.hpp
.
Whenever possible, use method get_arg_val
when checking command arguments to improve code readibility.
Description:
The function command
translates the command line arguments into calls to the core Stan services layer.
cmdstan/src/cmdstan/command.hpp
Line 283 in c48a435
This command is 900+ lines long. Running Cpplint on this results in the following:
src/cmdstan/command.hpp(1127): error cpplint: [readability/fn_size] Small and focused functions are preferred: command() has 951 non-comment lines (error triggered by exceeding 500 lines). [1]
The (relatively) new function get_arg_val
cmdstan/src/cmdstan/command.hpp
Lines 277 to 281 in c48a435
Additional Information:
This refactor will not in any way change the interface behavoir, but it might make the code easier to maintain.
Current Version:
v2.30.1