Skip to content

make: using SUNDIALS_TARGETS instead of LIBSUNDIALS #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

WardBrian
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Follow on to stan-dev/stan#3162 and stan-dev/math#2861, this change is for consistency and to allow users to use an external Sundials more easily.

After this we can clean this up in the Math makefiles: https://github.com/stan-dev/math/blob/98117fa4616d50d9544fed882c5a5c2b9803cf85/make/libraries#L84

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass, this is good to go.

@WardBrian WardBrian merged commit 125a45f into develop Mar 24, 2023
@WardBrian WardBrian deleted the feature/libsundials branch March 24, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants