Skip to content

Fix trailing slash on directories windows bug #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2020

Conversation

rok-cesnovar
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes #281

Originally planned to do this as part of #289 but that might take a bit longer to polish so we can fix this here

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar, Univ. of Ljubljana

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #294 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   90.11%   90.12%           
=======================================
  Files          12       12           
  Lines        2419     2421    +2     
=======================================
+ Hits         2180     2182    +2     
  Misses        239      239           
Impacted Files Coverage Δ
R/utils.R 70.78% <ø> (ø)
R/args.R 99.76% <100.00%> (+<0.01%) ⬆️
R/install.R 55.38% <100.00%> (ø)
R/model.R 88.21% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab21db...e5fba92. Read the comment docs.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jgabry jgabry merged commit 0e3069d into master Aug 27, 2020
@jgabry jgabry deleted the bugfix/trailing_slash_windows branch August 27, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output directory errors with trailing slash on Windows
3 participants