Fix processing lists of matrices (in data) #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Fixes #296.
This fixes a problem where lists of matrices were being converted to arrays of the wrong dimensions.
@rok-cesnovar @bbbales2 I think this PR is doing the right thing but we should be careful with it because I rewrote a bunch of the code and if it introduces any additional mistakes in data processing that would be particularly bad. @rok-cesnovar Can you take a look at the code and @bbbales2 if you by any chance have any spare time could you try to break this?
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: