Skip to content

Fix processing lists of matrices (in data) #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Sep 28, 2020

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes #296.

This fixes a problem where lists of matrices were being converted to arrays of the wrong dimensions.

@rok-cesnovar @bbbales2 I think this PR is doing the right thing but we should be careful with it because I rewrote a bunch of the code and if it introduces any additional mistakes in data processing that would be particularly bad. @rok-cesnovar Can you take a look at the code and @bbbales2 if you by any chance have any spare time could you try to break this?

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry requested a review from rok-cesnovar September 28, 2020 18:57
@jgabry jgabry changed the title Fix list of matrices Fix processing lists of matrices (in data) Sep 28, 2020
@bbbales2
Copy link
Member

bbbales2 commented Oct 2, 2020

This looks good to me (tested a little and I checked the code) though the test thing seems to disagree. Do we need to restart them though? I clicked one of the errors and it didn't look like a related message though I didn't put much effort into digging down. I clicked restart test anyway. Presumably they'll just fail in 30 minutes again if there's an actual problem.

@jgabry
Copy link
Member Author

jgabry commented Oct 5, 2020

Thanks @bbbales2. I just fixed a test that was failing so I think the checks should pass now.

@rok-cesnovar If you're not too busy can you glance at the code changes and see if you notice any potential problems? If you're too busy right now no worries this can wait a bit or I can ask someone else to take a look.

@codecov-commenter
Copy link

Codecov Report

Merging #302 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files          12       12           
  Lines        2427     2428    +1     
=======================================
+ Hits         2188     2189    +1     
  Misses        239      239           
Impacted Files Coverage Δ
R/data.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbebd3e...1d4daf5. Read the comment docs.

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rok-cesnovar rok-cesnovar merged commit 878da87 into master Oct 6, 2020
@rok-cesnovar rok-cesnovar deleted the fix-list-of-matrices branch October 6, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write_stan_json() doesn't preserve dimension of matrices in data
4 participants