Skip to content

Add sig_figs argument #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Add sig_figs argument #327

merged 5 commits into from
Oct 29, 2020

Conversation

rok-cesnovar
Copy link
Member

Fixes #313

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar, Uni. of Ljubljana

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@rok-cesnovar rok-cesnovar changed the title Sig figs Add sig_figs argument Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #327 into master will increase coverage by 0.00%.
The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   89.24%   89.24%           
=======================================
  Files          12       12           
  Lines        2538     2548   +10     
=======================================
+ Hits         2265     2274    +9     
- Misses        273      274    +1     
Impacted Files Coverage Δ
R/args.R 99.54% <83.33%> (-0.23%) ⬇️
R/model.R 89.65% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea13eba...e5f08b7. Read the comment docs.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! Optionally, maybe add a brief comment in the doc that increasing sig_figs increases the memory required?

@rok-cesnovar rok-cesnovar merged commit 44ee2ec into master Oct 29, 2020
@rok-cesnovar rok-cesnovar deleted the sig_figs branch October 29, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add output sig_figs
3 participants