Skip to content

Enable support for running M1-native code on macOS #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 27, 2020
Merged

Enable support for running M1-native code on macOS #375

merged 9 commits into from
Nov 27, 2020

Conversation

rok-cesnovar
Copy link
Member

Summary

Fixes #365

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Nico Kist
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@rok-cesnovar
Copy link
Member Author

For sanity checking we need to make sure:

remotes::install_github("stan-dev/cmdstanr@m1")
install_cmdstan(cores = 4, overwrite = TRUE)
f <- cmdstanr_example()

runs on M1 macs and Intel macs (this one is also confirmed by CI). Once we get both, this is good to go.

@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #375 (8625b7d) into master (9842076) will decrease coverage by 0.68%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   91.27%   90.58%   -0.69%     
==========================================
  Files          12       12              
  Lines        2544     2571      +27     
==========================================
+ Hits         2322     2329       +7     
- Misses        222      242      +20     
Impacted Files Coverage Δ
R/install.R 51.95% <36.00%> (-2.05%) ⬇️
R/utils.R 93.50% <42.85%> (-2.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9842076...8625b7d. Read the comment docs.

@nicokist
Copy link
Contributor

Thanks Rok, this branch works on M1.

@jgabry
Copy link
Member

jgabry commented Nov 27, 2020

Thanks @nicokist and @rok-cesnovar! Seems to work fine for my Intel mac too. @rok-cesnovar Can you add a NEWS item? Otherwise this looks good.

@rok-cesnovar rok-cesnovar merged commit b9ce4d9 into master Nov 27, 2020
@rok-cesnovar rok-cesnovar deleted the m1 branch November 27, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect the use of the M1 ARM-based CPU and suggest adding CXX
4 participants