Skip to content

Add output_basename #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2021
Merged

Add output_basename #471

merged 6 commits into from
Mar 17, 2021

Conversation

rok-cesnovar
Copy link
Member

Summary

Fixes #438 by adding an argument output_basename.

> fit <- mod$sample(data = data_file, chains = 4, output_basename = "custom")
> print(fit$output_files())
[1] "/tmp/RtmpHcV04N/custom-1.csv" "/tmp/RtmpHcV04N/custom-2.csv" "/tmp/RtmpHcV04N/custom-3.csv" "/tmp/RtmpHcV04N/custom-4.csv"

Combine that with output_dir to have completely predictable output CSV filepaths.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@rok-cesnovar
Copy link
Member Author

@wpetry @seth127 mind looking at this, if this works for you?

remotes::install_github("stan-dev/cmdstanr@output_basename"

to try it out.

@jgabry
Copy link
Member

jgabry commented Mar 17, 2021

This looks good, I just made one comment on the doc

@rok-cesnovar rok-cesnovar merged commit 3d85584 into master Mar 17, 2021
@rok-cesnovar rok-cesnovar deleted the output_basename branch March 17, 2021 20:04
@wpetry
Copy link

wpetry commented Mar 18, 2021

Looks good to me too. Thanks for implementing this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add file naming arguments to sample()
3 participants