Bugfix clearing stdout stderr on finish & cleanup #522
Conversation
…tinmodrak) - cleanup process_output, process_error_output code
| @@ -371,36 +371,6 @@ build_cmdstan <- function(dir, | |||
| ) | |||
| } | |||
|
|
|||
| # Removes files that are used to simplify switching to using threading, opencl or mpi. | |||
| clean_compile_helper_files <- function() { | |||
There was a problem hiding this comment.
This has not been needed for some time, we just haven't cleaned it up.
There was a problem hiding this comment.
Awesome, always nice to delete a bunch of code!
rok-cesnovar
changed the title
| } | ||
| stancflags_val <- paste0(stancflags_val, include_paths_flag, include_paths, " ") | ||
| } | ||
| stancflags_val <- include_paths_stanc3_args(include_paths) |
There was a problem hiding this comment.
This code is repeated in check_syntax, so I added a utility function with a test.
| @@ -60,9 +60,7 @@ is_rosetta2 <- function() { | |||
|
|
|||
| # Returns the type of make command to use to compile depending on the OS | |||
| make_cmd <- function() { | |||
| # CmdStan 2.21 introduced TBB that requires mingw32-make on Windows | |||
| ver <- .cmdstanr$VERSION | |||
| if (os_is_windows() && (is.null(ver) || ver >= "2.21")) { | |||
There was a problem hiding this comment.
This check for versions is not needed. CmdStan 2.20 and earlier will still work with mingw32-make (its just that 2.21 and on requires mingw32-make). The toolchain installation for Windows is made in such a way that users will always have mingw32-make (3.x or 4.x). Not to mention I doubt anyone uses CmdStan 2.20 with CmdStanR :)
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
- Coverage 92.78% 91.19% -1.60%
==========================================
Files 12 12
Lines 3062 3031 -31
==========================================
- Hits 2841 2764 -77
- Misses 221 267 +46
Continue to review full report at Codecov.
|
| @@ -371,36 +371,6 @@ build_cmdstan <- function(dir, | |||
| ) | |||
| } | |||
|
|
|||
| # Removes files that are used to simplify switching to using threading, opencl or mpi. | |||
| clean_compile_helper_files <- function() { | |||
There was a problem hiding this comment.
Awesome, always nice to delete a bunch of code!
Summary
Fix #517 by applying the suggestion by @martinmodrak. Fixes #493. Also a bit of cleanup (see comment).
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: