Skip to content

as_draws() #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2021
Merged

as_draws() #581

merged 3 commits into from
Nov 1, 2021

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Nov 1, 2021

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Closes #532

Adds as_draws() methods for CmdStanR's fitted model objects. Since this is just a wrapper around fit$draws(), the only argument is ..., which is passed to fit$draws() (so can include variables, inc_warmup, format, etc.).

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry requested a review from rok-cesnovar November 1, 2021 17:41
@jgabry jgabry changed the title As draws as_draws() Nov 1, 2021
Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merge once tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (9e41082) to head (81edaaf).
Report is 1120 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   91.37%   91.94%   +0.57%     
==========================================
  Files          12       12              
  Lines        3233     3191      -42     
==========================================
- Hits         2954     2934      -20     
+ Misses        279      257      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement posterior::as_draws() for cmdstanr objects
3 participants