Skip to content

Add Windows OpenCL instructions in the vignette #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

rok-cesnovar
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes #493

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@@ -0,0 +1,272 @@
<!DOCTYPE html>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included the .html, not sure if its required or not.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

Merging #602 (7de737a) into master (18c0f5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files          12       12           
  Lines        3262     3262           
=======================================
  Hits         3033     3033           
  Misses        229      229           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c0f5d...7de737a. Read the comment docs.

@jgabry
Copy link
Member

jgabry commented Feb 8, 2022

I just realized this was never merged, maybe because the macOS devel failure. Will rerun the checks now. I think this is ready otherwise, right?

@rok-cesnovar
Copy link
Member Author

Yeah, this is good to go. Thanks!

@rok-cesnovar rok-cesnovar merged commit fb9e953 into master Feb 9, 2022
@rok-cesnovar rok-cesnovar deleted the fix_opencl_vignette branch February 9, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows openCL compilation issue
3 participants