Skip to content

Describe how to efficiently save model fit objects #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

wlandau
Copy link
Collaborator

@wlandau wlandau commented Aug 9, 2023

Submission Checklist

  • [n/a] Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

As discussed in #340, this PR describes how to efficiently save model fit objects.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):

Eli Lilly and Company

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@wlandau wlandau requested a review from jgabry August 9, 2023 20:01
@jgabry
Copy link
Member

jgabry commented Aug 9, 2023

Great, thanks @wlandau. This looks good, but the checks are failing because save_object_qs is used as the label for multiple chunks.

@wlandau
Copy link
Collaborator Author

wlandau commented Aug 10, 2023

Sorry about that. Should be fixed in 8367448

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #816 (5a6597f) into master (b90c143) will not change coverage.
The diff coverage is n/a.

❗ Current head 5a6597f differs from pull request most recent head 8367448. Consider uploading reports for the commit 8367448 to get more accurate results

@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          12       12           
  Lines        4161     4161           
=======================================
  Hits         3673     3673           
  Misses        488      488           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants