Skip to content

Fix exposing functions under 2.33+ #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Exposing functions fails under 2.33+ since cmdstanr no longer needs to replace the auto return type with a plain type (this is done by stanc3 instead).

This PR fixes the handling of this between CmdStan versions

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass, go ahead and merge. Thanks!

@andrjohns
Copy link
Collaborator Author

Changes bundled as part of #843

@andrjohns andrjohns closed this Sep 11, 2023
@andrjohns andrjohns deleted the expose-funs-2.33 branch January 24, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants