Skip to content

Update Cmdstan doc to remove stanc2 references #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Builds locally
  • Declare copyright holder and open-source license: see below

Summary

Resolves #389
Resolves #372

This removes references to stanc2 from the cmdstan guide, as it is no longer shipped. It also adds two new flags to the list of stanc options, --info and --warn-pedantic.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian requested a review from rok-cesnovar August 30, 2021 18:45
Copy link
Member

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good, so I'm approving. So feel free to merge.

Before merging, I thought I'd ask if you think it makes sense to remove all reference to the "3" in "stanc3"? That's more of a developer issue and it seems a bit confusing to alternately talk about stanc and stanc3 in the doc. (I did check there were no more refs to stanc2.)

@WardBrian
Copy link
Member Author

We do have this language on the installation page:

As of release 2.22, the CmdStan Stan to C++ compiler is written in
OCaml. This compiler is called "stanc3" and has has its own
repository https://github.com/stan-dev/stanc3, from which pre-built
binaries for Linux, Mac, and Windows can be downloaded.

which I feel like is sufficiently explanatory of the 3 in the name

@WardBrian WardBrian merged commit 2462d51 into master Aug 31, 2021
@WardBrian WardBrian deleted the cmdstan-remove-stanc2 branch August 31, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CmdStan guide to stanc out of date CmdStan: New command line option in 2.27 is not documented
2 participants