guide compatability with ggplot2 >3.4.2 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
changed the title
|
This PR is now ready for review. |
stefanedwards
approved these changes
Oct 17, 2023
stefanedwards
added a commit
that referenced
this pull request
Nov 21, 2023
* Fixed compability with ggplot2 > 3.4.2 (see #30) * `%||%` is no longer an exported function for R > 4.4, as it should be included into R's base from v. 4.5. * Minor bugfix when no labels used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Stefan,
Apologies for the cold PR without posting an issue first.
The ggplot2 package has changed the implementation of the guide system, which means that the old S3 system will no longer work, see ggplot2's news file.
Unfortunately, these changes aren't fully backwards compatible, so packages implementing custom guides will need a few tweaks. This PR provides these tweaks for lemon. It is currently still work in progress (WIP) as I'm still trying to figure out what changes in ggplot2 would make the transition easier.
Best,
Teun