-
Notifications
You must be signed in to change notification settings - Fork 56
generates error constants based on unique indexes #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generates error constants based on unique indexes #360
Conversation
Why are you using the column names and not the index name? |
Initially, I was using the column names because those were used with the unique constraints. However, after looking into using index names, the generated constants seem more verbose with Postgres, and information about the columns are lost in Sqlite (assuming default index naming). Should I still go through with using the index name instead of the column name? Postgres:
Sqlite:
|
Yes, let's use the index names. Users can rename the indexes if they want, and in the future, we can expand aliases to allow aliasing indexes too |
Final comment. Update CHANGELOG.md with your changes, along with attribution (thanks @tlietz) |
Should the docs, or any tests be changed with this pull request? |
The docs need a lot of work. Any improvements are very welcome. At the moment though, I'm first making sure the CHANGELOG is up to date, I'll find time to dive deeply into improving the docs later. |
Closes #355
Let me know if I should change anything.