Angular: remove invalid defaults for start-storybook #31337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
104
to
107
| "items": { | ||
| "$ref": "#/definitions/styleElement" | ||
| }, | ||
| "default": "" | ||
| } | ||
| }, |
There was a problem hiding this comment.
style: Consider adding a default empty array [] for styles since it's an array type
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
valentinpalkovic
approved these changes
May 2, 2025
valentinpalkovic
changed the title
There was a problem hiding this comment.
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
104
to
+106
| "items": { | ||
| "$ref": "#/definitions/styleElement" | ||
| }, | ||
| "default": "" | ||
| } |
There was a problem hiding this comment.
style: Remove trailing whitespace after closing brace
Comment on lines
+120
to
121
| "additionalProperties": false | ||
| }, |
There was a problem hiding this comment.
style: Remove trailing whitespace after closing brace
|
@valentinpalkovic thanks for the quick merge 🎉 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR removes some invalid defaults from the builder schemas for angular CLI builders. This is important because in the future Nx will warn about them, and as-is they are not applied.
Specifically, there are default values of
""(an empty string) for values which should be an object. For now, Nx is skipping the application of this default. In the future, Nx will warn if it detects this.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
schema.jsonchanges in node_modulesDocumentation
No applicable docs
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Removed invalid default values from Angular CLI builder schemas to ensure proper type validation and prevent future Nx warnings.
stylesarray in both builder schemasstylePreprocessorOptionsobject in both builder schemasnulldefault forbrowserTargetincode/frameworks/angular/src/builders/start-storybook/schema.json💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!