Addon Vitest: Ensure vitest exclusions are relative to the project root, not cwd #31514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit f67d4ce.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 534 | 534 | 0 |
| Self size | 216 KB | 216 KB | 0 B |
| Dependency size | 58.69 MB | 58.76 MB | 🚨 +75 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 127 | 127 | 0 |
| Self size | 2.39 MB | 2.39 MB | 0 B |
| Dependency size | 22.05 MB | 22.13 MB | 🚨 +75 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 160 | 160 | 0 |
| Self size | 35 KB | 35 KB | 🚨 +129 B 🚨 |
| Dependency size | 23.19 MB | 23.26 MB | 🚨 +75 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 120 | 120 | 0 |
| Self size | 32 KB | 32 KB | 0 B |
| Dependency size | 20.16 MB | 20.23 MB | 🚨 +75 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 284 | 284 | 0 |
| Self size | 25 KB | 25 KB | 0 B |
| Dependency size | 43.48 MB | 43.56 MB | 🚨 +75 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 2 | 0 |
| Self size | 1.66 MB | 1.73 MB | 🚨 +75 KB 🚨 |
| Dependency size | 16 KB | 16 KB | 0 B |
| Bundle Size Analyzer | Link | Link |
valentinpalkovic
approved these changes
May 20, 2025
|
LGTM! Thanks @mrginglymus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31500
What I did
If you keep all your config in your
./.storybookdirectory, then your test patterns will likely be something like:["../stories/**/*.stories.ts", "../stories/**/*.mdx"]By default, addon-vitest only adds an ignore pattern of
**/*.mdx, which does not match the patterns above.This change ensures that the mdx exclusion glob is relative to the project root directory rather than cwd, to match the inclusion globs.
More refinement and testing required, I just thought of this on the way to bed.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Modified Vitest plugin to fix MDX file exclusion patterns by making them relative to the project root instead of the current working directory, addressing test file discovery issues.
code/addons/vitest/src/vitest-plugin/index.tsto usejoin(relative(root, process.cwd()), '**/*.mdx')for correct MDX exclusionsepimport frompathefor cross-platform path separator handlingreplaceAll(sep, '/')