Skip to content

CLI: Respect --skip-install in postinstall scripts #31605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 29, 2025

Closes #31596

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-31605-sha-b301b609. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information
Published version 0.0.0-pr-31605-sha-b301b609
Triggered by @ghengeveld
Repository storybookjs/storybook
Branch skip-install-in-sb-add
Commit b301b609
Datetime Fri May 30 13:26:26 UTC 2025 (1748611586)
Workflow run 15347815370

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31605

Greptile Summary

This PR adds a --skip-install option to the Storybook CLI's add command and postinstall scripts, allowing users to skip dependency installation steps when adding new addons.

  • Added skipInstall parameter to PostinstallOptions interface in code/lib/cli-storybook/src/add.ts
  • Modified postinstall.ts in Vitest addon to respect --skip-install flag and provide manual installation instructions
  • Added --skip-install CLI option to add command in code/lib/cli-storybook/src/bin/index.ts
  • Updated dependency installation logic to be skipped when flag is enabled
  • Added handling for Playwright installation to be skipped with appropriate user messaging

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels May 29, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented May 29, 2025

View your CI Pipeline Execution ↗ for commit b301b60.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 26s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-30 13:31:54 UTC

@ghengeveld ghengeveld merged commit ea7e262 into next May 30, 2025
58 checks passed
@ghengeveld ghengeveld deleted the skip-install-in-sb-add branch May 30, 2025 14:30
shilman pushed a commit that referenced this pull request May 31, 2025
CLI: Respect --skip-install in postinstall scripts
(cherry picked from commit ea7e262)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: storybook installs playwright even with --skip-install
2 participants