assert: refactor Test*FileExists and Test*DirExists tests to enable parallel testing #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
added
pkg-assert
In package assert, fix TestFileExists, TestNoFileExists, TestDirExists, TestNoDirExists to be able to run in parallel: - use t.TempDir() as the storage location for temporary created symlinks. This also allows the cleanup of that storage to be automatically handled by "go test". testing.T.TempDir is available since go1.15. - enable parallel testing on each test
In tests of the assert package, move more logic from each test into the helper getTempSymlinkPath.
Improve error reporting in getTempSymlinkPath by displaying the file paths.
dolmen
force-pushed
the
dolmen/assert-testing-parallel-TestFileDirExists
branch
from
99df383 to
e44f5a0
Compare
ccoVeille
approved these changes
Jun 16, 2025
alexandear
reviewed
Jun 16, 2025
| err := os.Symlink(file, link) | ||
| return link, err | ||
| } | ||
| func getTempSymlinkPath(t *testing.T, file string) string { |
There was a problem hiding this comment.
We can improve naming:
Suggested change
| func getTempSymlinkPath(t *testing.T, file string) string { | |
| func tempSymlinkPath(t *testing.T, file string) string { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
TestFileExists,TestNoFileExists,TestDirExistsandTestNoDirExiststo be able to run in parallel: we now use a temporary directory handled bygo testto create temporary files.Much infrastructure logic is moved to the helper
getTempSymlinkPathfor improved readability of each test suite.Changes
testing.T.TempDir(available since go1.15) as the storage location for files created temporarly for testing. This directory is handled bygo test, so this allows us to remove cleanup code.Test*Exists.Motivation
asserttests for faster dev loopRelated issues