Fixed didPanic to now detect panic(nil). #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
MariusVanDerWijden
previously approved these changes
Jul 26, 2019
|
ACK good catch |
sebastianst
previously approved these changes
Jul 26, 2019
|
Hes my brother 💯 |
boyan-soubachov
requested changes
Jun 28, 2020
|
|
||
| return |
There was a problem hiding this comment.
Is this line not redundant/pointless now?
There was a problem hiding this comment.
I think it's required when returning named return values.
assert/assertions_test.go
Outdated
| t.Error("didPanic should return true") | ||
| const panicMsg = "Panic!" | ||
|
|
||
| if funcDidPanic, msg := didPanic(func() { |
There was a problem hiding this comment.
Would it be a bit clearer if we separated these if statements into two lines, assignment and if check?
e.g.
funcDidPanic, msg := didPanic(func() {...})
if !funcDidPanic || msg != panicMsg {
...
}
There was a problem hiding this comment.
I think it's fine as it is. Reads as naturally as any other go code to me.
|
Any updates? :) |
boyan-soubachov
previously approved these changes
Mar 15, 2022
|
This PR needs to be updated and conflicts resolved before I can merge it. |
Previously, the function would not detect panic(nil) calls. In didPanic, removed the anonymous function call, instead, added named return values. Added extra test cases for the panic(nil) call.
RmbRT
dismissed stale reviews from boyan-soubachov, sebastianst, and MariusVanDerWijden
via
dfbd2d6
|
Rebased, resolved conflicts. |
boyan-soubachov
approved these changes
Mar 15, 2022
tisonkun
added a commit
to tisonkun/assert
that referenced
this pull request
Mar 23, 2022
This is cheery-picked from stretchr/testify#793. Signed-off-by: tison <[email protected]> Co-authored-by: RmbRT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the function would not detect panic(nil) calls.
In didPanic, removed the anonymous function call, instead,
added named return values. Added extra test cases for the
panic(nil) call.
Closes #794.