fix: ignore not found error to check for pkce prefix later #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13037852442Details
💛 - Coveralls |
hf
approved these changes
Jan 30, 2025
kangmingtay
pushed a commit
that referenced
this pull request
Mar 6, 2025
🤖 I have created a release *beep* *boop* --- ## [2.170.0](v2.169.0...v2.170.0) (2025-03-06) ### Features * improvements to config reloader, 100% coverage ([#1933](#1933)) ([21c2256](21c2256)) * increase test coverage in conf package to 100% ([#1937](#1937)) ([bc57c1c](bc57c1c)) ### Bug Fixes * enable SO_REUSEPORT in listener config ([#1936](#1936)) ([a474b80](a474b80)) * ignore not found error to check for pkce prefix later ([#1929](#1929)) ([fbbebcc](fbbebcc)) * log version & migration count ([#1934](#1934)) ([8078cdc](8078cdc)) * update figma token endpoint ([#1952](#1952)) ([18fbbb5](18fbbb5)) * use sys/unix instead of syscall ([#1953](#1953)) ([4a6d9bc](4a6d9bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wdoppenberg
pushed a commit
to wdoppenberg/supabase-auth
that referenced
this pull request
Jun 5, 2025
wdoppenberg
pushed a commit
to wdoppenberg/supabase-auth
that referenced
this pull request
Jun 5, 2025
🤖 I have created a release *beep* *boop* --- ## [2.170.0](supabase/auth@v2.169.0...v2.170.0) (2025-03-06) ### Features * improvements to config reloader, 100% coverage ([supabase#1933](supabase#1933)) ([21c2256](supabase@21c2256)) * increase test coverage in conf package to 100% ([supabase#1937](supabase#1937)) ([bc57c1c](supabase@bc57c1c)) ### Bug Fixes * enable SO_REUSEPORT in listener config ([supabase#1936](supabase#1936)) ([a474b80](supabase@a474b80)) * ignore not found error to check for pkce prefix later ([supabase#1929](supabase#1929)) ([fbbebcc](supabase@fbbebcc)) * log version & migration count ([supabase#1934](supabase#1934)) ([8078cdc](supabase@8078cdc)) * update figma token endpoint ([supabase#1952](supabase#1952)) ([18fbbb5](supabase@18fbbb5)) * use sys/unix instead of syscall ([supabase#1953](supabase#1953)) ([4a6d9bc](supabase@4a6d9bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
POST /verifyfails for email change when PKCE is used andGOTRUE_MAILER_SECURE_EMAIL_CHANGE_ENABLEDis enabled because the query to retrieve the token returns an error if the token is not found instead of trying again with thepkce_prefix