Skip to content

Add python 3.12 to the test suite #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Update to latest autoflake and add Python 3.12 to the test suite

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@silentworks silentworks requested a review from a team as a code owner March 23, 2024 12:52
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @silentworks - I've reviewed your changes and they look great!

General suggestions:

  • Verify that all dependencies are compatible with Python 3.12 to ensure smooth integration.
  • Consider adding a brief note in the documentation about the support for Python 3.12 and the update to autoflake.
  • Ensure that the CI pipeline successfully runs with the newly added Python version to confirm compatibility.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@silentworks silentworks merged commit 6a3d83e into main Mar 23, 2024
@silentworks silentworks deleted the chore/update-ci-python-versions branch March 23, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant