refactor(config): add exporter related settings #2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## reboot #2075 +/- ##
==========================================
- Coverage 92.08% 92.01% -0.07%
==========================================
Files 30 30
Lines 2187 2218 +31
==========================================
+ Hits 2014 2041 +27
- Misses 131 134 +3
- Partials 42 43 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sthaha
force-pushed
the
refactor-config
branch
4 times, most recently
from
58e03d1 to
7ab095c
Compare
vimalk78
reviewed
May 21, 2025
sthaha
force-pushed
the
refactor-config
branch
2 times, most recently
from
f12a552 to
4709cbe
Compare
This commit restructures config as follows
Configuration
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
log:
level: debug
format: text
host:
sysfs: /sys
procfs: /proc
monitor:
interval: 5s
staleness: 1s
rapl:
zones: []
exporter:
stdout:
enabled: true
prometheus:
enabled: true
debugCollectors:
- go
- process
web:
configFile: ""
debug:
pprof:
enabled: true
dev:
fake-cpu-meter:
enabled: false
zones: []
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Significant changes include:
* new exporter setting to hold all exporter related configs
* restructure stdout.enabled under exporter
* add prometheus exporter related settings for debugCollectors
* move enabled-pprof under `debug` related struct
* minor changes to flags
Signed-off-by: Sunil Thaha <[email protected]>
vimalk78
reviewed
May 21, 2025
config/config_test.go
Outdated
| args: []string{"--no-exporter.prometheus"}, | ||
| enabled: false, | ||
| }, { | ||
| name: "disable prometheus exporter with flag", |
vimalk78
approved these changes
May 21, 2025
sthaha
merged commit 25e21ed
into
sustainable-computing-io:reboot
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restructures config as follows
Significant changes include:
debugrelated struct