perf: iterate children using a for loop #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spread is considerably slower here than iterating through the converted children and pushing them individually. Additionally, spreading the args can result in a large number of params which can cause other problems (sometimes `push` will throw). I suspect the for loop is faster because `...convertChildren(...)` has to iterate the full set in order to allocate it to an array in memory, which it then has to iterate to spread as params. Whereas iterating through one at a time means we can add the child to the block without waiting for the entire iterable to finish.
|
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
Pull Request Test Coverage Report for Build 14146946524Details
💛 - Coveralls |
baseballyama
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spread is slower here than iterating through the converted children and pushing them individually.
Additionally, spreading the args can result in a large number of params which can cause other problems (sometimes
pushwill throw).I suspect the for loop is faster because
...convertChildren(...)has to iterate the full set in order to allocate it to an array in memory, which it then has to iterate to spread as params. Whereas iterating through one at a time means we can add the child to the block without waiting for the entire iterable to finish.i could be wrong, though. either way this fixes the rare edge case where you can try spread too many args to
push