Skip having the stream library as a dependency

[dhenneke]

We are having some trouble with the stream package because it only implements the Stream interface itself but doesn't support things like stream.Readable. This is problematic because we are including this library in a larger application (backstage) and it clashes with other dependencies that need some stream features (in our case pdfkit). Since it is provided by this package, a configured polyfill fallback in webpack doesn't work anymore because the dependency is favoured over the other.

#7341 aims to move it to a direct dependency, but for us, it woul be better to skip depending on the stream package. Maybe one can advice users to install it by themselves if they get problems? Or maybe make it a peerDependency so users can decide if they want to install it or not?

Using a more complete polyfill like stream-browserify would also be nice, but I assume this would again require a fork of the xml package.

[char0n]

I haven't found a reference of stream anything withing the code. We used the stream library in swagger-client library which is the dependency of swagger-ui, but we don't use it anymore and use more isomorphic approach. Let's try to remove it from deps and see if all the tests passes.

Update

Yeah, as you mentioned it's a dependency for xml package.

[char0n]

I've removed stream lib in 211643d and all the tests passed. Now I'm verifying that the appropriate pollyfix has been applied.

[char0n]

Webpack@4 applied stream-browserify and there hasn't been any significant increase in bundle sizes. I'll release this change in 4.0.0-rc.2

[dhenneke]

Webpack@4 applied stream-browserify and there hasn't been any significant increase in bundle sizes. I'll release this change in 4.0.0-rc.2

Awesome, thanks! Any plans when you want to release the rc.2? We are eager to try the new version and see if the issue is fixed on our end.

[char0n]

During today

[char0n]

Released in https://github.com/swagger-api/swagger-ui/releases/tag/v4.0.0-rc.2