Adopt Sendability in Remaining Models #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several structs already declared Sendable conformance. This PR adds support to (most of) the remaining ones. - `SymbolOccurrence` and `SymbolRelation` are easy and safe changes. - `IndexStoreDBError`, `PathMapping`, and `StoreUnitInfo` are similar, but I don't know if this change is beneficial. - `IndexStoreDB` contains an `UnsafeMutableRawPointer` so the best that we can do (with what I'm aware of) is `@unchecked Sendable`. Please let me know if any of these changes should be adjusted and/or how we might test this beyond visual inspection.
moshe-foreflight
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
reviewed
Jun 10, 2025
|
@swift-ci Please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several structs already declared Sendable conformance. This PR adds support to (most of) the remaining ones.
SymbolOccurrenceandSymbolRelationare easy and safe changes.IndexStoreDBError,PathMapping, andStoreUnitInfoare similar, but I don't know if this change is what you had in mind, @ahoppen.Less safe changes:
IndexDelegatecan be useful to wrap in a Swift actor, so I'd like to mark this as Sendable, but am unsure if this is wise, given there's mention of asynchronous behavior within that protocol.IndexStoreDBcontains anUnsafeMutableRawPointerso the best that we can do (with what I'm aware of) is@unchecked Sendable.Reviewers: Please let me know if any of these changes should be adjusted and/or how we might test this beyond visual inspection.
Addresses conversation on #248 and issues #250.