Merge main into release/6.0
#1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, `setpriority` only allows reduction of a process’s priority and doesn’t support priority elevation (unless you are a super user). I still think that it’s valuable to set the process’s priority based on the task priority when it is launched because many indexing processes never get their priority escalated and should thus run in the background. On Windows, we can elevate the process’s priority. rdar://127474245
We can have two targets with the same name in a SwiftPM workspace, one for a build target and one for the destination. We need to be able to tell them apart based on the run destination.
This allows us to fix a toolchain when using a `SwiftPMBuildSystem`, which is critical to ensure that a target gets prepared using the same toolchain that is used to index it and that is used for sourcekitd.
I found that 2 markers sometimes chooses very close color combinations like red-yellow and red-orange. Let’s add a third emoji marker to make it even easier to tell the log lanes apart.
Use 3 emoji markers in the index log
…-plugin Take run destinations into account for SwiftPM build targets
Set the priority of processes launched for background indexing
- Strip the `-index-system-modules` flag because it doesn’t work if no output file map is passed - Remove `-primary-file` when we’re merging all `.swift` files into one file - Fix an issue where errors during reduction would be rendered within the progress bar.
It looks to similar to the red and yellow emojis.
…dexing.md` This frees the name `Background Indexing.md` to contain documentation about how background indexing works.
…swift build` invocations during preparation The `BuildParameters` that we were previously inspecting contained some parameters that SwiftPM synthesizes and that weren’t specified on the command line. For example, it contains `-g` for all languages. This causes us to add `-Xswiftc -g -Xcc -g -Xcxx -g` to the `swift build` invocations for preparation, which is not necessary.
Remove orange emoji from the task ID emoji representation
…in-index-subcommand Allow enabling experimental features in the `debug index` subcommand
Fix a couple issue in the `debug reduce-swift-frontend` subcommand
…xing-doc Rename `Background Indexing.md` to `Enable Experimental Background Indexing.md`
Log the exit status of prepare and index processes to the index log
Inspect the build setup to determine the extra flags to pass to the `swift build` invocations during preparation
# Conflicts: # Sources/SKSwiftPMWorkspace/SwiftPMBuildSystem.swift
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the following PRs into
release/6.0:debug indexsubcommand #1440debug reduce-swift-frontendsubcommand #1442Background Indexing.mdtoEnable Experimental Background Indexing.md#1444swift buildinvocations during preparation #1445