Port SwiftPMBuildSystemTests to Swift Testing #2176
+178
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci test |
ahoppen
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Thank you. Looks good to me, just a couple minor comments inline. Also great to see that there aren’t any other issues with using Swift Testing in Swift CI.
And Swift CI failed because of a formatting issue. Can you run swift format -ipr . to format the patch?
Tests/BuildSystemIntegrationTests/SwiftPMBuildSystemTests.swift
Outdated
Show resolved
Hide resolved
Tests/BuildSystemIntegrationTests/SwiftPMBuildSystemTests.swift
Outdated
Show resolved
Hide resolved
Tests/BuildSystemIntegrationTests/SwiftPMBuildSystemTests.swift
Outdated
Show resolved
Hide resolved
owenv
force-pushed
the
owenv/swift-testing
branch
from
2e4a635 to
dfc7c7b
Compare
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test Windows |
|
Looks like test execution crashed on macOS while executing the first test 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for parameterizing these tests to use either SwiftPM's native or Swift Build based build system