Fix the issue of indexPrefixMap being unordered, which causes the IndexStoreDB path to be unpredictable. #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kila2
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
reviewed
Jun 11, 2025
Sources/SourceKitLSP/Workspace.swift
Outdated
Comment on lines
310
to
314
| if $0.original.count != $1.original.count { | ||
| return $0.original.count > $1.original.count | ||
| } else { | ||
| return $0.original < $1.original | ||
| } |
There was a problem hiding this comment.
I assume that you want to sort by the string’s length to prefer more specific paths, right? Could you add a short comment explaining that?
Also, could you format your source code as described in https://github.com/swiftlang/sourcekit-lsp/blob/main/CONTRIBUTING.md#formatting?
There was a problem hiding this comment.
Done. Thanks for the suggestion!
…exStoreDB path to be unpredictable.
Kila2
force-pushed
the
feature/sort_prefixmapper
branch
from
0ab1556 to
8ecd8f6
Compare
|
@swift-ci please test |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.