Skip to content

[5.9] Editorial review changes of PackageDescription documentation. #6471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

zkiraly
Copy link
Contributor

@zkiraly zkiraly commented Apr 24, 2023

Editorial review changes for the PackageDescription documentation update that was applied in 942a1e8

Motivation:

To assure the high quality of the PackageDescription documentation, an editorial review was conducted offline. The recommended changes are now presented for the community to ensure accuracy.

Modifications:

Only DocC documentation was changed. Several files in PackageDescription were changed, and the bulk of the changes are in Target.swift.

Result:

After the PR is merged, the PackageDescription documentation will be updated with the editorial review results.

@zkiraly
Copy link
Contributor Author

zkiraly commented Apr 24, 2023

@swift-ci please smoke test.

@neonichu
Copy link
Contributor

CI failure looks infra related

Cloning into 'swift-atomics'...
fatal: unable to access 'https://github.com/apple/swift-atomics.git/': Received HTTP code 503 from proxy after CONNECT

@zkiraly
Copy link
Contributor Author

zkiraly commented Apr 24, 2023

@swift-ci please smoke test.

2 similar comments
@zkiraly
Copy link
Contributor Author

zkiraly commented Apr 25, 2023

@swift-ci please smoke test.

@zkiraly
Copy link
Contributor Author

zkiraly commented Apr 25, 2023

@swift-ci please smoke test.

@zkiraly zkiraly merged commit 7a8f7f6 into swiftlang:main Apr 26, 2023
@zkiraly zkiraly deleted the 5.9-doc-update branch April 26, 2023 16:16
zkiraly added a commit to zkiraly/swift-package-manager that referenced this pull request May 2, 2023
…wiftlang#6471)

* Editorial review changes of PackageDescription documentation.

* Resolved merge conflicts.
---------

Co-authored-by: Zsolt Kiraly <[email protected]>
neonichu pushed a commit that referenced this pull request May 3, 2023
* [5.9] Documentation update. (#6434)

* Updated documentation for BuildSettings.
* Updated documentation for PackageDescription.

* [5.9] Editorial review changes of PackageDescription documentation. (#6471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants