Disallow static linking core libraries in swift test

[MaxDesiatov]

This is currently not supported and we should show a proper error message in this case.

Resolves rdar://117908112.

[MaxDesiatov]

cc @grynspan this may need to be updated when swift-testing support lands, unless you can confirm that it doesn't support static linking either?

[MaxDesiatov]

@swift-ci test

[grynspan]

cc @grynspan this may need to be updated when swift-testing support lands, unless you can confirm that it doesn't support static linking either?

swift-testing is agnostic here. As it's also just a package, it only needs the symbols it uses to eventually exist, and isn't too concerned with the state of the linker.

[MaxDesiatov]

Great, then you'll just need to make this static linking check specific to XCTest in your swift-testing PR, in case mine is merged first 🙂

[neonichu]

Hm, why aren't we just removing the option? It seems a bit weird to have an option that 100% leads to an error.

[MaxDesiatov]

We can't remove it since it's a linker option shared with swift build.

[neonichu]

In that case, I think we should move the option so that we can have it only apply to build

[MaxDesiatov]

In that case, I think we should move the option so that we can have it only apply to build

What's the best place to move it? SwiftTestTool has access to GlobalOptions, which contains both BuildOptions and LinkerOptions.

[neonichu]

I think we would move it to BuildToolOptions?

[MaxDesiatov]

@swift-ci test

[MaxDesiatov]

@swift-ci test windows

[MaxDesiatov]

I think we would move it to BuildToolOptions?

Doesn't seem to be currently possible, as we construct BuildParameters in SwiftTool.swift, before BuildToolOptions are even available. Are there any alternatives, or should I just revert the last commit to get back to the initial error message implementation of this?

[neonichu]

One option could be moving the static stdlib option to createBuildSystem() like the other build-only options such as explicitProduct.

[MaxDesiatov]

@swift-ci test

[MaxDesiatov]

@swift-ci test windows

[MaxDesiatov]

@swift-ci test windows