Make swift test --show-code-cov-path work with swift-testing
#7094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
changed the title
swift test --show-code-cov-path works when swift-testing is enabled.swift test --show-code-cov-path work with swift-testing
…is enabled. This PR ensures that the aforementioned option behaves correctly when `--enable-experimental-swift-testing` is passed. As it stands, `--show-code-cov-path` is implemented as a subcommand but behaves like an option; this PR removes the subcommand so that it "just works" without regard for other options. A longer-term solution could be to make it into a proper subcommand (e.g. `swift test show-path code-coverage`.) That would ensure that we would get appropriate output from Swift Argument Parser when mixing it with other (nonsensical) options.
grynspan
force-pushed
the
jgrynspan/show-code-cov-path-swift-testing
branch
from
99d31e7 to
846c4e8
Compare
grynspan
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please test |
|
@swift-ci please test Windows |
MaxDesiatov
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the aforementioned option behaves correctly when
--enable-experimental-swift-testingis passed.As it stands,
--show-code-cov-pathis implemented as a subcommand but behaves like an option; this PR removes the subcommand so that it "just works" without regard for other options.A longer-term solution could be to make it into a proper subcommand (e.g.
swift test show-path code-coverage.) That would ensure that we would get appropriate output from Swift Argument Parser when mixing it with other (nonsensical) options.